[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230210234722.4cf0934f@xps-13>
Date: Fri, 10 Feb 2023 23:47:22 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Alexander Aring <alex.aring@...il.com>,
Stefan Schmidt <stefan@...enfreihafen.org>,
linux-wpan@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Paolo Abeni <pabeni@...hat.com>,
Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
David Girault <david.girault@...vo.com>,
Romuald Despres <romuald.despres@...vo.com>,
Frederic Blain <frederic.blain@...vo.com>,
Nicolas Schodet <nico@...fr.eu.org>,
Guilhem Imberton <guilhem.imberton@...vo.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH wpan-next 1/6] ieee802154: Add support for user scanning
requests
Hi Jakub,
kuba@...nel.org wrote on Fri, 10 Feb 2023 10:59:25 -0800:
> On Fri, 10 Feb 2023 11:18:43 +0100 Miquel Raynal wrote:
> > > > + /* Monitors are not allowed to perform scans */
> > > > + if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR)
> > >
> > > extack ?
> >
> > Thanks for pointing at it, I just did know about it. I did convert
> > most of the printk's into extack strings. Shall I keep both or is fine
> > to just keep the extack thing?
> >
> > For now I've dropped the printk's, please tell me if this is wrong.
>
> That's right - just the extack, we don't want duplicated prints.
Thanks for the confirmation.
Series ready, I need to test it further just to verify there is no
unwanted regression, I'll send it early next week.
Thanks,
Miquèl
Powered by blists - more mailing lists