[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230209205309.57e75fdf@kernel.org>
Date: Thu, 9 Feb 2023 20:53:09 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, davem@...emloft.net, pabeni@...hat.com,
edumazet@...gle.com, tariqt@...dia.com, saeedm@...dia.com,
jacob.e.keller@...el.com, gal@...dia.com, kim.phillips@....com,
moshe@...dia.com
Subject: Re: [patch net-next 0/7] devlink: params cleanups and
devl_param_driverinit_value_get() fix
On Thu, 9 Feb 2023 16:43:01 +0100 Jiri Pirko wrote:
> The primary motivation of this patchset is the patch #6, which fixes an
> issue introduced by 075935f0ae0f ("devlink: protect devlink param list
> by instance lock") and reported by Kim Phillips <kim.phillips@....com>
> (https://lore.kernel.org/netdev/719de4f0-76ac-e8b9-38a9-167ae239efc7@amd.com/)
> and my colleagues doing mlx5 driver regression testing.
>
> The basis idea is that devl_param_driverinit_value_get() could be
> possible to the called without holding devlink intance lock in
> most of the cases (all existing ones in the current codebase),
> which would fix some mlx5 flows where the lock is not held.
>
> To achieve that, make sure that the param value does not change between
> reloads with patch #2.
>
> Also, convert the param list to xarray which removes the worry about
> list_head consistency when doing lockless lookup.
>
> The rest of the patches are doing some small related cleanup of things
> that poke me in the eye during the work.
Acked-by: Jakub Kicinski <kuba@...nel.org>
Powered by blists - more mailing lists