netdev - Re: [PATCH iproute2-next] tc: m_ct: add support for helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+btY0hReqhnviDK@t14s.localdomain>
Date:   Fri, 10 Feb 2023 17:20:35 -0800
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>,
        David Ahern <dsahern@...il.com>, stephen@...workplumber.org,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Davide Caratti <dcaratti@...hat.com>
Subject: Re: [PATCH iproute2-next] tc: m_ct: add support for helper

On Fri, Feb 10, 2023 at 04:43:13PM -0500, Xin Long wrote:
> This patch is to add the setup and dump for helper in tc ct action
> in userspace, and the support in kernel was added in:
> 
>   https://lore.kernel.org/netdev/cover.1667766782.git.lucien.xin@gmail.com/
> 
> here is an example for usage:
> 
>   # ip link add dummy0 type dummy
>   # tc qdisc add dev dummy0 ingress
> 
>   # tc filter add dev dummy0 ingress proto ip flower ip_proto \
>     tcp ct_state -trk action ct helper ipv4-tcp-ftp

It is not wrong as is, but the example could limit it to port 21.

> 
>   # tc filter show dev dummy0 ingress
>     filter protocol ip pref 49152 flower chain 0 handle 0x1
>       eth_type ipv4
>       ip_proto tcp
>       ct_state -trk
>       not_in_hw
>         action order 1: ct zone 0 helper ipv4-tcp-ftp pipe
>         index 1 ref 1 bind
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>