[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230210192057.4927b002@kernel.org>
Date: Fri, 10 Feb 2023 19:20:57 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Ido Schimmel <idosch@...dia.com>
Cc: netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
razor@...ckwall.org, roopa@...dia.com, petrm@...dia.com,
mlxsw@...dia.com
Subject: Re: [PATCH net-next 3/4] bridge: mcast: Move validation to a policy
On Thu, 9 Feb 2023 09:18:51 +0200 Ido Schimmel wrote:
> + if (nla_len(attr) != sizeof(struct br_mdb_entry)) {
> + NL_SET_ERR_MSG_MOD(extack, "Invalid MDBA_SET_ENTRY attribute length");
> + return -EINVAL;
Well, you're just moving it, but NL_SET_ERR_MSG_ATTR() would be better.
We shouldn't be adding _MOD() in the core implementation of the family.
Powered by blists - more mailing lists