netdev - Re: [PATCH v2] 9p/rdma: unmap receive dma buffer in rdma_request()/post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+bfrI+u98gM9a8j@codewreck.org>
Date:   Sat, 11 Feb 2023 09:22:04 +0900
From:   asmadeus@...ewreck.org
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     Leon Romanovsky <leon@...nel.org>,
        v9fs-developer@...ts.sourceforge.net, netdev@...r.kernel.org,
        ericvh@...il.com, lucho@...kov.net, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        linux_oss@...debyte.com, tom@...ngridcomputing.com,
        weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH v2] 9p/rdma: unmap receive dma buffer in
 rdma_request()/post_recv()

Leon Romanovsky wrote on Wed, Jan 04, 2023 at 09:39:07AM +0200:
> On Wed, Jan 04, 2023 at 10:04:24AM +0800, Zhengchao Shao wrote:
> > When down_interruptible() or ib_post_send() failed in rdma_request(),
> > receive dma buffer is not unmapped. Add unmap action to error path.
> > Also if ib_post_recv() failed in post_recv(), dma buffer is not unmapped.
> > Add unmap action to error path.
> >
> > Fixes: fc79d4b104f0 ("9p: rdma: RDMA Transport Support for 9P")
> > Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> Reviewed-by: Leon Romanovsky <leonro@...dia.com>

Sorry for the delay -- I have no way of testing it but it looks sane,
I'll submit it when 6.3 opens up in a week or two.

Thanks for the patch & Leon for the review.

-- 
Dominique