netdev - Re: [PATCH net-next] devlink: stop using NL_SET_ERR_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230210195241.35c3a7ce@kernel.org>
Date:   Fri, 10 Feb 2023 19:52:41 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next] devlink: stop using NL_SET_ERR_MSG_MOD

On Thu,  9 Feb 2023 14:20:45 -0800 Jacob Keller wrote:
> NL_SET_ERR_MSG_MOD inserts the KBUILD_MODNAME and a ':' before the actual
> extended error message. The devlink feature hasn't been able to be compiled
> as a module since commit f4b6bcc7002f ("net: devlink: turn devlink into a
> built-in").
> 
> Stop using NL_SET_ERR_MSG_MOD, and just use the base NL_SET_ERR_MSG. This
> aligns the extended error messages better with the NL_SET_ERR_MSG_ATTR
> messages as well.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>

Acked-by: Jakub Kicinski <kuba@...nel.org>

Thanks!