netdev - Re: [PATCH v3 1/4] wifi: brcmfmac: Rename Cypress 89459 to BCM4355

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9dbfa3d-6599-94b9-0176-e25bb074b2c7@marcan.st>
Date:   Sat, 11 Feb 2023 21:46:09 +0900
From:   Hector Martin <marcan@...can.st>
To:     Arend Van Spriel <arend.vanspriel@...adcom.com>,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     Alexander Prutskov <alep@...ress.com>,
        Chi-Hsien Lin <chi-hsien.lin@...ress.com>,
        Wright Feng <wright.feng@...ress.com>,
        Ian Lin <ian.lin@...ineon.com>,
        Soontak Lee <soontak.lee@...ress.com>,
        Joseph chuang <jiac@...ress.com>,
        Sven Peter <sven@...npeter.dev>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Aditya Garg <gargaditya08@...e.com>,
        Jonas Gorski <jonas.gorski@...il.com>, asahi@...ts.linux.dev,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/4] wifi: brcmfmac: Rename Cypress 89459 to BCM4355

On 11/02/2023 20.23, Arend Van Spriel wrote:
> On February 11, 2023 11:09:02 AM Hector Martin <marcan@...can.st> wrote:
> 
>> On 10/02/2023 12.42, Ping-Ke Shih wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Hector Martin <marcan@...can.st>
>>>> Sent: Friday, February 10, 2023 10:50 AM
>>>> To: Arend van Spriel <aspriel@...il.com>; Franky Lin 
>>>> <franky.lin@...adcom.com>; Hante Meuleman
>>>> <hante.meuleman@...adcom.com>; Kalle Valo <kvalo@...nel.org>; David S. 
>>>> Miller <davem@...emloft.net>; Eric
>>>> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo 
>>>> Abeni <pabeni@...hat.com>
>>>> Cc: Alexander Prutskov <alep@...ress.com>; Chi-Hsien Lin 
>>>> <chi-hsien.lin@...ress.com>; Wright Feng
>>>> <wright.feng@...ress.com>; Ian Lin <ian.lin@...ineon.com>; Soontak Lee 
>>>> <soontak.lee@...ress.com>; Joseph
>>>> chuang <jiac@...ress.com>; Sven Peter <sven@...npeter.dev>; Alyssa 
>>>> Rosenzweig <alyssa@...enzweig.io>;
>>>> Aditya Garg <gargaditya08@...e.com>; Jonas Gorski <jonas.gorski@...il.com>; 
>>>> asahi@...ts.linux.dev;
>>>> linux-wireless@...r.kernel.org; brcm80211-dev-list.pdl@...adcom.com; 
>>>> SHA-cyfmac-dev-list@...ineon.com;
>>>> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Hector Martin 
>>>> <marcan@...can.st>; Arend van Spriel
>>>> <arend.vanspriel@...adcom.com>
>>>> Subject: [PATCH v3 1/4] wifi: brcmfmac: Rename Cypress 89459 to BCM4355
>>>>
>>>> The commit that introduced support for this chip incorrectly claimed it
>>>> is a Cypress-specific part, while in actuality it is just a variant of
>>>> BCM4355 silicon (as evidenced by the chip ID).
>>>>
>>>> The relationship between Cypress products and Broadcom products isn't
>>>> entirely clear but given what little information is available and prior
>>>> art in the driver, it seems the convention should be that originally
>>>> Broadcom parts should retain the Broadcom name.
>>>>
>>>> Thus, rename the relevant constants and firmware file. Also rename the
>>>> specific 89459 PCIe ID to BCM43596, which seems to be the original
>>>> subvariant name for this PCI ID (as defined in the out-of-tree bcmdhd
>>>> driver).
>>>>
>>>> v2: Since Cypress added this part and will presumably be providing
>>>> its supported firmware, we keep the CYW designation for this device.
>>>>
>>>> v3: Drop the RAW device ID in this commit. We don't do this for the
>>>> other chips since apparently some devices with them exist in the wild,
>>>> but there is already a 4355 entry with the Broadcom subvendor and WCC
>>>> firmware vendor, so adding a generic fallback to Cypress seems
>>>> redundant (no reason why a device would have the raw device ID *and* an
>>>> explicitly programmed subvendor).
>>>
>>> Do you really want to add changes of v2 and v3 to commit message? Or,
>>> just want to let reviewers know that? If latter one is what you want,
>>> move them after s-o-b with delimiter ---
>>
>> Both; I thought those things were worth mentioning in the commit message
>> as it stands on its own, and left the version tags in so reviewers know
>> when they were introduced.
> 
> The commit message is documenting what we end up with post reviewing so 
> patch versions are meaningless there. Of course useful information that 
> came up in review cycles should end up in the commit message.
> 

Do you really want me to respin this again just to remove 8 characters
from the commit message? I know it doesn't have much meaning post review
but it's not unheard of either, grep git logs and you'll find plenty of
examples.

- Hector