netdev - Re: [PATCH net-next v4 2/9] net/sched: act_pedit, setup offload action for action stats query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMkTdJ0shmSGkLsL1j2d-R9nxxMJBtc30XtYBWs5CzqFCw@mail.gmail.com>
Date:   Sun, 12 Feb 2023 09:59:00 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Oz Shlomo <ozsh@...dia.com>
Cc:     netdev@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>,
        Roi Dayan <roid@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        Marcelo Ricardo Leitner <mleitner@...hat.com>,
        Simon Horman <simon.horman@...igine.com>,
        Baowen Zheng <baowen.zheng@...igine.com>,
        Edward Cree <ecree.xilinx@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [PATCH net-next v4 2/9] net/sched: act_pedit, setup offload
 action for action stats query

On Sun, Feb 12, 2023 at 8:26 AM Oz Shlomo <ozsh@...dia.com> wrote:
>
> A single tc pedit action may be translated to multiple flow_offload
> actions.
> Offload only actions that translate to a single pedit command value.
>
> Signed-off-by: Oz Shlomo <ozsh@...dia.com>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal

> ---
> Change log:
>
> V1 -> V2:
>     - Add extack message on error
>     - Assign the flow action id outside the for loop.
>       Ensure the rest of the pedit actions follow the assigned id.
>
> V2 -> V3:
>     - Fix last_cmd initialization
>
> V3 -> V4:
>     - Compare all action types to the first action
> ---
>  net/sched/act_pedit.c | 23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
> index c42fcc47dd6d..35ebe5d5c261 100644
> --- a/net/sched/act_pedit.c
> +++ b/net/sched/act_pedit.c
> @@ -545,7 +545,28 @@ static int tcf_pedit_offload_act_setup(struct tc_action *act, void *entry_data,
>                 }
>                 *index_inc = k;
>         } else {
> -               return -EOPNOTSUPP;
> +               struct flow_offload_action *fl_action = entry_data;
> +               u32 cmd = tcf_pedit_cmd(act, 0);
> +               int k;
> +
> +               switch (cmd) {
> +               case TCA_PEDIT_KEY_EX_CMD_SET:
> +                       fl_action->id = FLOW_ACTION_MANGLE;
> +                       break;
> +               case TCA_PEDIT_KEY_EX_CMD_ADD:
> +                       fl_action->id = FLOW_ACTION_ADD;
> +                       break;
> +               default:
> +                       NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload");
> +                       return -EOPNOTSUPP;
> +               }
> +
> +               for (k = 1; k < tcf_pedit_nkeys(act); k++) {
> +                       if (cmd != tcf_pedit_cmd(act, k)) {
> +                               NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload");
> +                               return -EOPNOTSUPP;
> +                       }
> +               }
>         }
>
>         return 0;
> --
> 1.8.3.1
>