netdev - Re: [PATCH net-next v4 4/9] net/sched: introduce flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoM=ewhz5UBZQXco-PDgDkxGFcKRtSQZa1sYN4APkTgt94A@mail.gmail.com>
Date:   Sun, 12 Feb 2023 10:14:30 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Oz Shlomo <ozsh@...dia.com>
Cc:     netdev@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>,
        Roi Dayan <roid@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        Marcelo Ricardo Leitner <mleitner@...hat.com>,
        Simon Horman <simon.horman@...igine.com>,
        Baowen Zheng <baowen.zheng@...igine.com>,
        Edward Cree <ecree.xilinx@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [PATCH net-next v4 4/9] net/sched: introduce flow_offload action cookie

On Sun, Feb 12, 2023 at 8:26 AM Oz Shlomo <ozsh@...dia.com> wrote:
>
> Currently a hardware action is uniquely identified by the <id, hw_index>
> tuple. However, the id is set by the flow_act_setup callback and tc core
> cannot enforce this, and it is possible that a future change could break
> this. In addition, <id, hw_index> are not unique across network namespaces.
>
> Uniquely identify the action by setting an action cookie by the tc core.
> Use the unique action cookie to query the action's hardware stats.
>
> Signed-off-by: Oz Shlomo <ozsh@...dia.com>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

LGTM.
Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal

> ---
>  include/net/flow_offload.h | 2 ++
>  net/sched/act_api.c        | 1 +
>  net/sched/cls_api.c        | 1 +
>  3 files changed, 4 insertions(+)
>
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index 0400a0ac8a29..d177bf5f0e1a 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -228,6 +228,7 @@ struct flow_action_cookie *flow_action_cookie_create(void *data,
>  struct flow_action_entry {
>         enum flow_action_id             id;
>         u32                             hw_index;
> +       unsigned long                   act_cookie;
>         enum flow_action_hw_stats       hw_stats;
>         action_destr                    destructor;
>         void                            *destructor_priv;
> @@ -610,6 +611,7 @@ struct flow_offload_action {
>         enum offload_act_command  command;
>         enum flow_action_id id;
>         u32 index;
> +       unsigned long cookie;
>         struct flow_stats stats;
>         struct flow_action action;
>  };
> diff --git a/net/sched/act_api.c b/net/sched/act_api.c
> index f4fa6d7340f8..917827199102 100644
> --- a/net/sched/act_api.c
> +++ b/net/sched/act_api.c
> @@ -192,6 +192,7 @@ static int offload_action_init(struct flow_offload_action *fl_action,
>         fl_action->extack = extack;
>         fl_action->command = cmd;
>         fl_action->index = act->tcfa_index;
> +       fl_action->cookie = (unsigned long)act;
>
>         if (act->ops->offload_act_setup) {
>                 spin_lock_bh(&act->tcfa_lock);
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index 5b4a95e8a1ee..bfabc9c95fa9 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -3577,6 +3577,7 @@ int tc_setup_action(struct flow_action *flow_action,
>                 for (k = 0; k < index ; k++) {
>                         entry[k].hw_stats = tc_act_hw_stats(act->hw_stats);
>                         entry[k].hw_index = act->tcfa_index;
> +                       entry[k].act_cookie = (unsigned long)act;
>                 }
>
>                 j += index;
> --
> 1.8.3.1
>