netdev - Re: [net-next Patch V4 2/4] octeontx2-pf: qos send queues management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO6PR18MB44671631BA1F0148A8B9D405DEDD9@CO6PR18MB4467.namprd18.prod.outlook.com>
Date:   Mon, 13 Feb 2023 06:19:01 +0000
From:   Hariprasad Kelam <hkelam@...vell.com>
To:     Simon Horman <simon.horman@...igine.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "saeedm@...dia.com" <saeedm@...dia.com>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "tariqt@...dia.com" <tariqt@...dia.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "maxtram95@...il.com" <maxtram95@...il.com>,
        Naveen Mamindlapalli <naveenm@...vell.com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "hariprasad.netdev@...il.com" <hariprasad.netdev@...il.com>
Subject: Re: [net-next Patch V4 2/4] octeontx2-pf: qos send queues management



> -----Original Message-----
> From: Simon Horman <simon.horman@...igine.com>
> On Fri, Feb 10, 2023 at 04:40:49PM +0530, Hariprasad Kelam wrote:
> > From: Subbaraya Sundeep <sbhatta@...vell.com>
> >
> > Current implementation is such that the number of Send queues (SQs)
> > are decided on the device probe which is equal to the number of online
> > cpus. These SQs are allocated and deallocated in interface open and c
> > lose calls respectively.
> >
> > This patch defines new APIs for initializing and deinitializing Send
> > queues dynamically and allocates more number of transmit queues for
> > QOS feature.
> >
> > Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> > Signed-off-by: Hariprasad Kelam <hkelam@...vell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@...vell.com>
> > ---
> >  .../marvell/octeontx2/af/rvu_debugfs.c        |   5 +
> >  .../ethernet/marvell/octeontx2/nic/Makefile   |   2 +-
> >  .../marvell/octeontx2/nic/otx2_common.c       |  40 ++-
> >  .../marvell/octeontx2/nic/otx2_common.h       |  29 +-
> >  .../ethernet/marvell/octeontx2/nic/otx2_pf.c  |  51 ++-
> >  .../marvell/octeontx2/nic/otx2_txrx.c         |  25 +-
> >  .../marvell/octeontx2/nic/otx2_txrx.h         |   3 +-
> >  .../ethernet/marvell/octeontx2/nic/otx2_vf.c  |   9 +-
> >  .../net/ethernet/marvell/octeontx2/nic/qos.h  |  19 ++
> >  .../ethernet/marvell/octeontx2/nic/qos_sq.c   | 290 ++++++++++++++++++
> >  10 files changed, 430 insertions(+), 43 deletions(-)  create mode
> > 100644 drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> >  create mode 100644
> > drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c
> 
> nit: this patch is a little long
> 
ACK, will split this patch.
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> > index ef10aef3cda0..050be13dfa46 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> > @@ -463,12 +463,14 @@ static int otx2_tx_napi_handler(struct otx2_nic
> *pfvf,
> >  			break;
> >  		}
> >
> > -		if (cq->cq_type == CQ_XDP) {
> > +		qidx = cq->cq_idx - pfvf->hw.rx_queues;
> > +
> > +		if (cq->cq_type == CQ_XDP)
> >  			otx2_xdp_snd_pkt_handler(pfvf, sq, cqe);
> > -		} else {
> > -			otx2_snd_pkt_handler(pfvf, cq, sq, cqe, budget,
> > -					     &tx_pkts, &tx_bytes);
> > -		}
> > +		else
> > +			otx2_snd_pkt_handler(pfvf, cq, &pfvf->qset.sq[qidx],
> > +					     cqe, budget, &tx_pkts, &tx_bytes);
> > +
> >
> 
> nit: there are now two blank lines here
ACK, will fix in next version.

Thanks,
Hariprasad k
> 
> >  		cqe->hdr.cqe_type = NIX_XQE_TYPE_INVALID;
> >  		processed_cqe++;