netdev - Re: [PATCH net] mlxsw: spectrum: Fix incorrect parsing depth after reload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Feb 2023 13:01:27 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ido Schimmel <idosch@...dia.com>
Cc:     Petr Machata <petrm@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com,
        Maksym Yaremchuk <maksymy@...dia.com>
Subject: Re: [PATCH net] mlxsw: spectrum: Fix incorrect parsing depth after
 reload

On Sat, 11 Feb 2023 18:21:45 +0200 Ido Schimmel wrote:
> > Sounds quite odd TBH, something doesn't get de-registered during _down()
> > but is registered again during _up()?  
> 
> It's not really de-registered / registered. The FIB multipath hash
> policy isn't changed when devlink reload is issued, so the driver
> doesn't bother decrementing the parsing depth reference count. The diff
> below does decrement the reference count on reload_down(). Tested it
> without the current fix and it seems to work. If you prefer, I can send
> a v2 with this diff squashed into the current fix.

That does seem cleaner to me, less error prone in case some actual clean
up is missed later. So if you don't mind - yes, I'd prefer the patch
from your reply, thanks!