netdev - Re: [PATCH] Bluetooth: hci_core: Fix poential Use-after-Free bug in hci_remove_adv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <868017d2-c85f-20a1-292f-0b97ab8bf752@molgen.mpg.de>
Date:   Mon, 13 Feb 2023 09:19:27 +0100
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Zheng Wang <zyytlz.wz@....com>
Cc:     marcel@...tmann.org, hackerzheng666@...il.com,
        alex000young@...il.com, johan.hedberg@...il.com,
        luiz.dentz@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com,
        linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_core: Fix poential Use-after-Free bug in
 hci_remove_adv_monitor

Dear Zheng,


Thank you for your patch.

Am 10.02.23 um 05:10 schrieb Zheng Wang:
> In hci_remove_adv_monitor, if it gets into HCI_ADV_MONITOR_EXT_MSFT case,
> the function will free the monitor and print its handle after that.
> 
> Fix it by switch the order.

… by switch*ing* …

There is a small typo in the commit message summary/title: po*t*ential

> Fixes: 7cf5c2978f23 ("Bluetooth: hci_sync: Refactor remove Adv Monitor")
> Signed-off-by: Zheng Wang <zyytlz.wz@....com>
> ---
>   net/bluetooth/hci_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

[…]


Kind regards,

Paul