netdev - RE: [PATCH v4 2/4] Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <3b468450c72441efb1935ea27f79ff96@quicinc.com>
Date:   Mon, 13 Feb 2023 08:27:57 +0000
From:   "Tim Jiang (QUIC)" <quic_tjiang@...cinc.com>
To:     Luiz Augusto von Dentz <luiz.dentz@...il.com>
CC:     Steev Klimaszewski <steev@...i.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Gross <agross@...nel.org>,
        "Bjorn Andersson" <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Sven Peter <sven@...npeter.dev>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        Mark Pearson <markpearson@...ovo.com>
Subject: RE: [PATCH v4 2/4] Bluetooth: hci_qca: Add support for QTI Bluetooth
 chip wcn6855

Hi Luiz and all:
  I am QC bt host guys,  today I sync up with qc btfw team and conclude following result:
1: as I mentioned before, qca2066 and wcn6855 are the same chip family, and they can share the same btfw patch, and distinguish by using different nvm based on board id.
2: I upload the btfw previously for qca2066 , you can refer to https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=2ba1beaae0c649ce8a50baecc8df9e81cd524e65 , and also wcn6855 can share to use btfw patch and nvm with qca2066.

3:steev patch does not include read board id part logical , I think it is better combine the steev  patch and my patch into one.

Regards.
Tim

-----Original Message-----
From: Luiz Augusto von Dentz <luiz.dentz@...il.com> 
Sent: Friday, February 10, 2023 5:38 AM
To: Tim Jiang (QUIC) <quic_tjiang@...cinc.com>
Cc: Steev Klimaszewski <steev@...i.org>
Subject: Re: [PATCH v4 2/4] Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855

Hi Tim,

On Thu, Feb 9, 2023 at 12:45 AM Tim Jiang (QUIC) <quic_tjiang@...cinc.com> wrote:
>
> Hi steev:
>
> 6855 and 2066 are the same chip, the difference is 6855 use 2 ANT and 2066 use 3 ANT , but we have many nvm configs for 2066 and 6855 , that is the same , you can refer to I ever add support for 6855 usb .

Could you please review Steev changes, also if you could please refactor the code regarding the soc_type, making the necessary field as part of the data structure should make it a lot easier to add support for new configurations without having to change the code in multiple places.

> Regards.
> Tim
>
>

--
Luiz Augusto von Dentz