netdev - Re: [RFC PATCH net-next] selftests: forwarding: add a test for MAC Merge layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <873579ddv0.fsf@nvidia.com>
Date:   Mon, 13 Feb 2023 11:51:37 +0100
From:   Petr Machata <petrm@...dia.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Michal Kubecek <mkubecek@...e.cz>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Rui Sousa <rui.sousa@....com>,
        Ferenc Fejes <ferenc.fejes@...csson.com>,
        Pranavi Somisetty <pranavi.somisetty@....com>,
        Harini Katakam <harini.katakam@....com>,
        <UNGLinuxDriver@...rochip.com>, "Petr Machata" <petrm@...dia.com>,
        Ido Schimmel <idosch@...dia.com>,
        Aaron Conole <aconole@...hat.com>
Subject: Re: [RFC PATCH net-next] selftests: forwarding: add a test for MAC
 Merge layer


Vladimir Oltean <vladimir.oltean@....com> writes:

> +# Borrowed from mlxsw/qos_lib.sh, message adapted.
> +bail_on_lldpad()
> +{
> +	if systemctl is-active --quiet lldpad; then
> +		cat >/dev/stderr <<-EOF
> +		WARNING: lldpad is running
> +
> +			lldpad will likely autoconfigure the MAC Merge layer,
> +			while this test will configure it manually. One of them
> +			is arbitrarily going to overwrite the other. That will
> +			cause spurious failures (or, unlikely, passes) of this
> +			test.
> +		EOF
> +		exit 1
> +	fi
> +}

This would be good to have unified. Can you make the function reusable,
with a generic or parametrized message? I should be able to carve a bit
of time later to move it to lib.sh, migrate the mlxsw selftests, and
drop the qos_lib.sh copy.