netdev - Re: [PATCH bpf-next] selftests/bpf: Cross-compile bpftool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874jroa8k1.fsf@all.your.base.are.belong.to.us>
Date:   Tue, 14 Feb 2023 10:41:02 +0100
From:   Björn Töpel <bjorn@...nel.org>
To:     Zachary Leaf <zachary.leaf@....com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     Björn Töpel <bjorn@...osinc.com>,
        Jean-Philippe Brucker <jean-philippe@...aro.org>,
        linux-kselftest@...r.kernel.org,
        Anders Roxell <anders.roxell@...aro.org>,
        linux-morello@...lists.linaro.org,
        Quentin Monnet <quentin@...valent.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: Cross-compile bpftool

Zachary Leaf <zachary.leaf@....com> writes:

> Hi Bjorn,
>
> Thanks for the patch, I've tested it and it works for me.

Good!

> I have a minor suggestion but otherwise happy to see this getting fixed.
>
> ...
>
>
> -TEST_GEN_PROGS_EXTENDED += $(DEFAULT_BPFTOOL)
> +TEST_GEN_PROGS_EXTENDED += $(TRUNNER_BPFTOOL)
>
> Ensure the target arch bpftool is copied into the kselftest_bpf_install
> dir by selftests/lib.mk instead of always the default/host version.

Good one. I'll spin a v2, and also fix Quentin's "double-slash".


Björn