netdev - Re: [v2 PATCH] xfrm: Zero padding when dumping algos and encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+uHS/XnQEzqLh/o@gauss3.secunet.de>
Date:   Tue, 14 Feb 2023 14:06:19 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        Hyunwoo Kim <v4bel@...ori.io>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <imv4bel@...il.com>, <netdev@...r.kernel.org>
Subject: Re: [v2 PATCH] xfrm: Zero padding when dumping algos and encap

On Thu, Feb 09, 2023 at 03:02:11PM +0100, Sabrina Dubroca wrote:
> 2023-02-09, 09:09:52 +0800, Herbert Xu wrote:
> > v2 fixes the mistaken type of XFRMA_ALG_COMP for x->encap.
> > 
> > ---8<---
> > When copying data to user-space we should ensure that only valid
> > data is copied over.  Padding in structures may be filled with
> > random (possibly sensitve) data and should never be given directly
> > to user-space.
> > 
> > This patch fixes the copying of xfrm algorithms and the encap
> > template in xfrm_user so that padding is zeroed.
> > 
> > Reported-by: syzbot+fa5414772d5c445dac3c@...kaller.appspotmail.com
> > Reported-by: Hyunwoo Kim <v4bel@...ori.io>
> > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> 
> Thanks Herbert.
> Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

Applied, thanks a lot everyone!