[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y+r78ZUqIsvaWjQG@Laptop-X1>
Date: Tue, 14 Feb 2023 11:11:45 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Matthieu Baerts <matthieu.baerts@...sares.net>
Cc: netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org,
Jakub Kicinski <kuba@...nel.org>,
"David S . Miller" <davem@...emloft.net>,
Martin KaFai Lau <martin.lau@...ux.dev>,
Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
John Fastabend <john.fastabend@...il.com>,
KP Singh <kpsingh@...nel.org>,
Stanislav Fomichev <sdf@...gle.com>,
Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
Mykola Lysenko <mykolal@...com>,
Felix Maurer <fmaurer@...hat.com>,
Davide Caratti <dcaratti@...hat.com>
Subject: Re: [PATCH bpf] selftests/bpf: enable mptcp before testing
On Mon, Feb 13, 2023 at 05:28:19PM +0100, Matthieu Baerts wrote:
> But again, I'm not totally against that, I'm just saying that if these
> tests are executed in dedicated netns, this modification is not needed
> when using a vanilla kernel ;-)
>
> Except if I misunderstood and these tests are not executed in dedicated
> netns?
I tried on my test machine, it looks the test is executed in init netns.
I modified my patch by setting the net.mptcp.enabled to 1 without setting
it back. You can find the value is changed after testing.
# cat /proc/sys/net/mptcp/enabled
0
# ./test_progs -t mptcp
#127/1 mptcp/base:OK
#127 mptcp:OK
Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
# cat /proc/sys/net/mptcp/enabled
1
Thanks
Hangbin
Powered by blists - more mailing lists