netdev - [PATCH net-next 0/5] net/sched: Retire some tc qdiscs and classifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230214134915.199004-1-jhs@mojatatu.com>
Date:   Tue, 14 Feb 2023 08:49:10 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     netdev@...r.kernel.org
Cc:     xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        stephen@...workplumber.org, dsahern@...il.com,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: [PATCH net-next 0/5] net/sched: Retire some tc qdiscs and classifiers

The CBQ + dsmark qdiscs and the tcindex + rsvp classifiers have served us for
over 2 decades. Unfortunately, they have not been getting much attention due
to reduced usage. While we dont have a good metric for tabulating how much use
a specific kernel feature gets, for these specific features we observed that
some of the functionality has been broken for some time and no users complained.
In addition, syzkaller has been going to town on most of these and finding
issues; and while we have been fixing those issues, at times it becomes obvious
that we would need to perform bigger surgeries to resolve things found while
getting a syzkaller fix in place. After some discussion we feel that in order
to reduce the maintenance burden it is best to retire them.

This patchset leaves the UAPI alone. I could send another version which deletes
the UAPI as well. AFAIK, this has not been done before - so it wasnt clear what
how to handle UAPI. It seems legit to just delete it but we would need to
coordinate with iproute2 (given they sync up with kernel uapi headers). There
are probably other users we don't know of that copy kernel headers.
If folks feel differently I will resend the patches deleting UAPI for these
qdiscs and classifiers.

I will start another thread on iproute2 before sending any patches to iproute2.

Jamal Hadi Salim (5):
  net/sched: Retire CBQ qdisc
  net/sched: Retire ATM qdisc
  net/sched: Retire dsmark qdisc
  net/sched: Retire tcindex classifier
  net/sched: Retire rsvp classifier

 include/net/tc_wrapper.h                      |   15 -
 net/sched/Kconfig                             |   81 -
 net/sched/Makefile                            |    6 -
 net/sched/cls_rsvp.c                          |   26 -
 net/sched/cls_rsvp.h                          |  764 --------
 net/sched/cls_rsvp6.c                         |   26 -
 net/sched/cls_tcindex.c                       |  716 -------
 net/sched/sch_atm.c                           |  706 -------
 net/sched/sch_cbq.c                           | 1727 -----------------
 net/sched/sch_dsmark.c                        |  518 -----
 .../tc-testing/tc-tests/filters/rsvp.json     |  203 --
 .../tc-testing/tc-tests/filters/tcindex.json  |  227 ---
 .../tc-testing/tc-tests/qdiscs/atm.json       |   94 -
 .../tc-testing/tc-tests/qdiscs/cbq.json       |  184 --
 .../tc-testing/tc-tests/qdiscs/dsmark.json    |  140 --
 15 files changed, 5433 deletions(-)
 delete mode 100644 net/sched/cls_rsvp.c
 delete mode 100644 net/sched/cls_rsvp.h
 delete mode 100644 net/sched/cls_rsvp6.c
 delete mode 100644 net/sched/cls_tcindex.c
 delete mode 100644 net/sched/sch_atm.c
 delete mode 100644 net/sched/sch_cbq.c
 delete mode 100644 net/sched/sch_dsmark.c
 delete mode 100644 tools/testing/selftests/tc-testing/tc-tests/filters/rsvp.json
 delete mode 100644 tools/testing/selftests/tc-testing/tc-tests/filters/tcindex.json
 delete mode 100644 tools/testing/selftests/tc-testing/tc-tests/qdiscs/atm.json
 delete mode 100644 tools/testing/selftests/tc-testing/tc-tests/qdiscs/cbq.json
 delete mode 100644 tools/testing/selftests/tc-testing/tc-tests/qdiscs/dsmark.json

-- 
2.34.1