netdev - Re: [PATCH net-next] netlink-specs: add rx-push to ethtool family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8db21c13-b1d7-ad8b-08ce-590e1f06743f@amd.com>
Date:   Tue, 14 Feb 2023 10:29:07 -0800
From:   Shannon Nelson <shannon.nelson@....com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [PATCH net-next] netlink-specs: add rx-push to ethtool family

On 2/13/23 8:32 PM, Jakub Kicinski wrote:
> Commit 5b4e9a7a71ab ("net: ethtool: extend ringparam set/get APIs for rx_push")
> added a new attr for configuring rx-push, right after tx-push.
> Add it to the spec, the ring param operation is covered by
> the otherwise sparse ethtool spec.

Thanks for catching that
Reviewed-by: Shannon Nelson <shannon.nelson@....com>

> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> Cc: Shannon Nelson <shannon.nelson@....com>
> ---
>   Documentation/netlink/specs/ethtool.yaml | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 82f4e6f8ddd3..08b776908d15 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -171,6 +171,9 @@ doc: Partial family for Ethtool Netlink.
>         -
>           name: tx-push
>           type: u8
> +      -
> +        name: rx-push
> +        type: u8
> 
>     -
>       name: mm-stat
> @@ -320,6 +323,7 @@ doc: Partial family for Ethtool Netlink.
>               - tcp-data-split
>               - cqe-size
>               - tx-push
> +            - rx-push
>         dump: *ring-get-op
>       -
>         name: rings-set
> @@ -339,6 +343,7 @@ doc: Partial family for Ethtool Netlink.
>               - tcp-data-split
>               - cqe-size
>               - tx-push
> +            - rx-push
>       -
>         name: rings-ntf
>         doc: Notification for change in ring params.
> --
> 2.39.1
>