[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y+wB9hcZVUuaYj5H@x130>
Date: Tue, 14 Feb 2023 13:49:42 -0800
From: Saeed Mahameed <saeed@...nel.org>
To: Alexander Lobakin <alexandr.lobakin@...el.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Eric Dumazet <edumazet@...gle.com>,
Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
Tariq Toukan <tariqt@...dia.com>, Roi Dayan <roid@...dia.com>,
Maor Dickman <maord@...dia.com>
Subject: Re: [net-next 01/15] net/mlx5: Lag, Let user configure multiport
eswitch
On 14 Feb 18:07, Alexander Lobakin wrote:
>From: Saeed Mahameed <saeed@...nel.org>
>Date: Fri, 10 Feb 2023 14:18:07 -0800
>
[...]
> +static int mlx5_devlink_esw_multiport_set(struct devlink *devlink, u32 id,
>> + struct devlink_param_gset_ctx *ctx)
>> +{
>> + struct mlx5_core_dev *dev = devlink_priv(devlink);
>> + int err = 0;
>> +
>> + if (!MLX5_ESWITCH_MANAGER(dev))
>> + return -EOPNOTSUPP;
>> +
>> + if (ctx->val.vbool)
>> + err = mlx5_lag_mpesw_enable(dev);
>> + else
>> + mlx5_lag_mpesw_disable(dev);
>> +
>> + return err;
>
>How about
>
> if (ctx->val.vbool)
> return mlx5_lag_mpesw_enable(dev);
> else
> mlx5_lag_mpesw_disable(dev);
>
> return 0;
>
>?
Makes sense, will do the change.
Thanks.
Powered by blists - more mailing lists