netdev - Re: [PATCH net] net/sched: tcindex: search key must be 16 bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoM=Y6ogum2Np8ebhmKxuK4xW7ax9=wd+_FfXDUbjVneEWg@mail.gmail.com>
Date:   Tue, 14 Feb 2023 17:53:42 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Pedro Tammela <pctammela@...atatu.com>, netdev@...r.kernel.org,
        xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net] net/sched: tcindex: search key must be 16 bits

On Tue, Feb 14, 2023 at 5:46 PM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> On Mon, 13 Feb 2023 22:47:29 -0300
> Pedro Tammela <pctammela@...atatu.com> wrote:
>
> > diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c
> > index ba7f22a49..6640e75ea 100644
> > --- a/net/sched/cls_tcindex.c
> > +++ b/net/sched/cls_tcindex.c
> > @@ -503,7 +503,7 @@ tcindex_set_parms(struct net *net, struct tcf_proto *tp, unsigned long base,
> >               /* lookup the filter, guaranteed to exist */
> >               for (cf = rcu_dereference_bh_rtnl(*fp); cf;
> >                    fp = &cf->next, cf = rcu_dereference_bh_rtnl(*fp))
> > -                     if (cf->key == handle)
> > +                     if (cf->key == (u16)handle)
> >                               break;
>
> Rather than truncating silently. I think the code should first test that handle is
> not outside of range and return EINVAL instead.

Stephen,
It is a fix to a fix that is on -net right now. Note: tcindex will
disappear shortly altogether from the tree - we are deleting it. Is it
worth making the change?

cheers,
jamal