netdev - Re: [PATCH net-next 0/5] net/sched: Retire some tc qdiscs and classifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMmcMWrLueyaEco6r+VDbgLDmLf7O=80a8Rd+AJo-ScQOQ@mail.gmail.com>
Date:   Tue, 14 Feb 2023 18:52:18 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
        xiyou.wangcong@...il.com, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, stephen@...workplumber.org, dsahern@...il.com
Subject: Re: [PATCH net-next 0/5] net/sched: Retire some tc qdiscs and classifiers

On Tue, Feb 14, 2023 at 6:22 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 14 Feb 2023 18:05:23 -0500 Jamal Hadi Salim wrote:
> > Looking at that code - the user is keeping their own copy of the uapi
> > and listening to generated events from the kernel.
>
> I searched the repo for TCA_TCINDEX_CLASSID - I don't see the local
> copy of the header. Can you point me?

Sorry, I was wrong, this tool's configure script pulls those headers
on the host from whatever kernel uapi path (eg on my debian machine :
/usr/src/linux/include ).
If it doesnt find the headers it wont generate the build in the
Makefile. So if at some point the uapi was deleted it just wont
compile code to listen to cbq, dsmark etc.
So it will work in either case (of deleting or keeping the uapi
around). It may be a bad sample space - but if we do keep the uapi,
how long would that be for?

cheers,
jamal