netdev - Re: [PATCH net-next 04/10] devlink: health: Don't try to add trace with NULL msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230213222210.4f027963@kernel.org>
Date:   Mon, 13 Feb 2023 22:22:10 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Moshe Shemesh <moshe@...dia.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...dia.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 04/10] devlink: health: Don't try to add trace
 with NULL msg

On Mon, 13 Feb 2023 15:14:12 +0200 Moshe Shemesh wrote:
> In case devlink_health_report() msg argument is NULL a warning is
> triggered, but then continue and try to print a trace with NULL pointer.
> 
> Fix it to skip trace call if msg pointer is NULL.

The trace macros take NULLs, can you double check?
Same story with adding a note why this is harmless as patch 2