netdev - Re: [PATCH net-next v3] igc: offload queue max SDU from tc-taprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230213224003.1af75612@kernel.org>
Date:   Mon, 13 Feb 2023 22:40:03 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@...el.com>
Cc:     "intel-wired-lan@...osl.org" <intel-wired-lan@...osl.org>,
        "Gomes, Vinicius" <vinicius.gomes@...el.com>,
        "naamax.meir@...ux.intel.com" <naamax.meir@...ux.intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "leon@...nel.org" <leon@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "tee.min.tan@...ux.intel.com" <tee.min.tan@...ux.intel.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Neftin, Sasha" <sasha.neftin@...el.com>
Subject: Re: [PATCH net-next v3] igc: offload queue max SDU from tc-taprio

On Tue, 14 Feb 2023 06:27:17 +0000 Zulkifli, Muhammad Husaini wrote:
> > > +	if (tx_ring->max_sdu > 0) {
> > > +		max_sdu = tx_ring->max_sdu +
> > > +			  (skb_vlan_tagged(skb) ? VLAN_HLEN : 0);
> > > +
> > > +		if (skb->len > max_sdu)  
> > 
> > You should increment some counter here. Otherwise it's a silent discard.  
> 
> I am thinking to use tx_dropped counters for this. Is it ok?

Yup!

> > > +			goto skb_drop;
> > > +	}
> > > +
> > >  	if (!tx_ring->launchtime_enable)
> > >  		goto done;
> > >
> > > @@ -1606,6 +1615,11 @@ static netdev_tx_t igc_xmit_frame_ring(struct sk_buff *skb,  
> > >  	dev_kfree_skb_any(first->skb);  
> > 
> > first->skb is skb, as far as I can tell, you can reshuffle this code to
> > avoid adding the new return flow.  
> 
> What we try to do is to check the current max_sdu size at the
> beginning stage of the func() and drop it quickly.

I understand, what I'm saying is that the code which is already here
can be reused, it currently operates on first->skb but it can as well
use skb. And then you'll be able to jump to the same statement, rather
than have to create a separate return.