[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7a6c0263d698ccc821b2c7ef38c0063745f44743.camel@redhat.com>
Date: Tue, 14 Feb 2023 10:05:41 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Pedro Tammela <pctammela@...atatu.com>, netdev@...r.kernel.org
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org
Subject: Re: [PATCH net-next 1/3] net/sched: act_nat: transition to percpu
stats and rcu
On Fri, 2023-02-10 at 17:27 -0300, Pedro Tammela wrote:
> diff --git a/net/sched/act_nat.c b/net/sched/act_nat.c
> index 74c74be33..fb986d97c 100644
> --- a/net/sched/act_nat.c
> +++ b/net/sched/act_nat.c
> @@ -40,6 +40,7 @@ static int tcf_nat_init(struct net *net, struct nlattr *nla, struct nlattr *est,
> bool bind = flags & TCA_ACT_FLAGS_BIND;
> struct nlattr *tb[TCA_NAT_MAX + 1];
> struct tcf_chain *goto_ch = NULL;
> + struct tcf_nat_parms *nparm, *oparm;
> struct tc_nat *parm;
> int ret = 0, err;
> struct tcf_nat *p;
Please respect the reverse x-mas tree above.
> @@ -289,6 +306,16 @@ static int tcf_nat_dump(struct sk_buff *skb, struct tc_action *a,
> return -1;
> }
>
> +static void tcf_nat_cleanup(struct tc_action *a)
> +{
> + struct tcf_nat_parms *parms;
> + struct tcf_nat *p = to_tcf_nat(a);
Same here.
Thanks,
Paolo
Powered by blists - more mailing lists