netdev - Re: [PATCH net-next 2/3] net: skbuff: cache one skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <559d2f60eb97033ad4ddd2963232e49962a2efe2.camel@redhat.com>
Date:   Wed, 15 Feb 2023 20:08:40 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Alexander Lobakin <aleksander.lobakin@...el.com>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        willemb@...gle.com, fw@...len.de
Subject: Re: [PATCH net-next 2/3] net: skbuff: cache one skb_ext for use by
 GRO

On Wed, 2023-02-15 at 19:08 +0100, Alexander Lobakin wrote:
> From: Jakub Kicinski <kuba@...nel.org>
> Date: Wed, 15 Feb 2023 09:45:42 -0800
> 
> > On Wed, 15 Feb 2023 09:41:13 +0100 Paolo Abeni wrote:
> > > I'm wondering if napi_reuse_skb() should be touched, too? Even it's not
> > > directly used by the following patch...
> > 
> > I didn't touch it because I (sadly) don't have access to any driver
> > using GRO frags to test :(  But I certainly can.
> > 
> > What about __kfree_skb_defer() and napi_consume_skb() (basically 
> > the other two napi_skb_cache_put() callers) ?
> > 
> 
> Sounds good. Basically any caller of napi_skb_cache_put() can be
> switched to recycle extensions.
> But you certainly need to have a pool instead of just one pointer then,
> since napi_consume_skb() will return a lot if exts are actively used :)

This could be also a point to (initially) exclude napi_consume_skb()
and keep the (initial) implementation as simple as possible.

If the expected use-case more related to forwarded traffic, local
traffic or independent from such consideration?

Cheers,

Paolo