netdev - Re: wilc1000 MAC address is 00:00:00:00:00:00

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e455e26830a0d8f2ce728461b74e6dbd4b315df5.camel@sipsolutions.net>
Date:   Wed, 15 Feb 2023 21:14:10 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Dan Williams <dcbw@...hat.com>, Ajay.Kathat@...rochip.com,
        kvalo@...nel.org, heiko.thiery@...il.com
Cc:     michael@...le.cc, kuba@...nel.org, Claudiu.Beznea@...rochip.com,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Amisha.Patel@...rochip.com, thaller@...hat.com,
        bgalvani@...hat.com, Sripad.Balwadgi@...rochip.com
Subject: Re: wilc1000 MAC address is 00:00:00:00:00:00

On Fri, 2023-02-10 at 15:28 -0600, Dan Williams wrote:
> > 
> > In wilc1000, the bus interface is up in probe but we don't have
> > access
> > to mac address via register until the driver starts the wilc firmware
> > because of design limitation. This information is only available
> > after
> > the MAC layer is initialized.
> 
> So... initialize the MAC layer and read the address, then stop the card
> until dev open which reloads and reinits? That's what eg Atmel does

For a more modern example, iwlwifi also ;-)

You should also load the firmware async, so it becomes:

probe
 -> load firmware

firmware success callback
 - boot device
 - read information
 - register with mac80211
 - shut down device

mac80211 start callback
 - boot device again
 - etc.

johannes