netdev - Re: [PATCH v3 0/5] Bluetooth: hci_mrvl: Add serdev support for 88W8997

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Feb 2023 21:41:00 +0100
From:   Francesco Dolcini <francesco@...cini.it>
To:     Luiz Augusto von Dentz <luiz.dentz@...il.com>
Cc:     Francesco Dolcini <francesco@...cini.it>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-bluetooth@...r.kernel.org,
        Marcel Holtmann <marcel@...tmann.org>,
        linux-arm-kernel@...ts.infradead.org,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH v3 0/5] Bluetooth: hci_mrvl: Add serdev support for
 88W8997

Hello Luiz

On Wed, Feb 15, 2023 at 12:36:34PM -0800, Luiz Augusto von Dentz wrote:
> On Mon, Feb 13, 2023 at 4:09 AM Francesco Dolcini <francesco@...cini.it> wrote:
> >
> > From: Francesco Dolcini <francesco.dolcini@...adex.com>
> >
> > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes
> > support for changing the baud rate. The command to change the baud rate is
> > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth
> > interfaces) from NXP.
> >
> > v3:
> >  - Use __hci_cmd_sync_status instead of __hci_cmd_sync
> >
> > v2:
> >  - Fix the subject as pointed out by Krzysztof. Thanks!
> >  - Fix indentation in marvell-bluetooth.yaml
> >  - Fix compiler warning for kernel builds without CONFIG_OF enabled
> >
> > Stefan Eichenberger (5):
> >   dt-bindings: bluetooth: marvell: add 88W8997
> >   dt-bindings: bluetooth: marvell: add max-speed property
> >   Bluetooth: hci_mrvl: use maybe_unused macro for device tree ids
> >   Bluetooth: hci_mrvl: Add serdev support for 88W8997
> >   arm64: dts: imx8mp-verdin: add 88W8997 serdev to uart4
> >
> >  .../bindings/net/marvell-bluetooth.yaml       | 20 ++++-
> >  .../dts/freescale/imx8mp-verdin-wifi.dtsi     |  5 ++
> >  drivers/bluetooth/hci_mrvl.c                  | 90 ++++++++++++++++---
> >  3 files changed, 104 insertions(+), 11 deletions(-)
> >
> > --
> > 2.25.1
> 
> There seems to be missing one patch 5/5:
> 
> https://patchwork.kernel.org/project/bluetooth/list/?series=721269
> 
> Other than that the Bluetooth parts seem fine, and perhaps can be
> merged if the patch above is not really required.

In v3 I decided to not send it to the BT mailing list, since this is
supposed to go through Shawn and the iMX/SOC tree.

Given that it would be great if you could apply patches 1-4.

Thanks,
Francesco