netdev - Re: [PATCH bpf] selftests/bpf: enable mptcp before testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+xU8i7BCwXJuqlw@Laptop-X1>
Date:   Wed, 15 Feb 2023 11:43:46 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Martin KaFai Lau <martin.lau@...ux.dev>
Cc:     Matthieu Baerts <matthieu.baerts@...sares.net>,
        netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Mykola Lysenko <mykolal@...com>,
        Felix Maurer <fmaurer@...hat.com>,
        Davide Caratti <dcaratti@...hat.com>
Subject: Re: [PATCH bpf] selftests/bpf: enable mptcp before testing

On Tue, Feb 14, 2023 at 11:22:58AM -0800, Martin KaFai Lau wrote:
> On 2/13/23 7:11 PM, Hangbin Liu wrote:
> > On Mon, Feb 13, 2023 at 05:28:19PM +0100, Matthieu Baerts wrote:
> > > But again, I'm not totally against that, I'm just saying that if these
> > > tests are executed in dedicated netns, this modification is not needed
> > > when using a vanilla kernel ;-)
> > > 
> > > Except if I misunderstood and these tests are not executed in dedicated
> > > netns?
> > 
> > I tried on my test machine, it looks the test is executed in init netns.
> 
> The new test is needed to run under its own netns whenever possible. The
> existing mptcp test should be changed to run in its own netns also. Then
> changing any pernet sysctl (eg. mptcp.enabled) is a less concern to other
> tests. You can take a look at how other tests doing it (eg. decap_sanity.c).

Thanks for the reference. I will update the patch to make mptcp run in it's
own netns.

Hangbin