netdev - Re: [PATCH net-next] net: phy: Uninitialized variables in yt8531_link_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+xd+AkAJpTnLY+h@kadam>
Date:   Wed, 15 Feb 2023 07:22:16 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Frank Sae <Frank.Sae@...or-comm.com>
Cc:     Peter Geis <pgwipeout@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: Uninitialized variables in
 yt8531_link_change_notify()

On Wed, Feb 15, 2023 at 09:51:56AM +0800, Frank Sae wrote:
> 
> 
> On 2023/2/14 23:48, Dan Carpenter wrote:
> 
> > @@ -1534,9 +1534,9 @@ static void yt8531_link_change_notify(struct phy_device *phydev)
> >  {
> >  	struct device_node *node = phydev->mdio.dev.of_node;
> >  	bool tx_clk_adj_enabled = false;
> > -	bool tx_clk_1000_inverted;
> > -	bool tx_clk_100_inverted;
> > -	bool tx_clk_10_inverted;
> > +	bool tx_clk_1000_inverted = false;
> > +	bool tx_clk_100_inverted = false;
> > +	bool tx_clk_10_inverted = false;
> 
> Thanks, please keep reverse christmas tree.
> 

Right.  Good point.

regards,
dan carpenter