lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e066920c-26a9-0f0e-3304-2b9940274d57@starfivetech.com> Date: Wed, 15 Feb 2023 15:46:09 +0800 From: yanhong wang <yanhong.wang@...rfivetech.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, <linux-riscv@...ts.infradead.org>, <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org> CC: "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Emil Renner Berthing <kernel@...il.dk>, Richard Cochran <richardcochran@...il.com>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Peter Geis <pgwipeout@...il.com> Subject: Re: [PATCH v4 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names On 2023/2/7 15:59, Krzysztof Kozlowski wrote: > On 07/02/2023 03:43, yanhong wang wrote: >> >> >> On 2023/1/18 23:47, Krzysztof Kozlowski wrote: >>> On 18/01/2023 07:16, Yanhong Wang wrote: >>>> Some boards(such as StarFive VisionFive v2) require more than one value >>>> which defined by resets property, so the original definition can not >>>> meet the requirements. In order to adapt to different requirements, >>>> adjust the maxitems number definition. >>>> >>>> Signed-off-by: Yanhong Wang <yanhong.wang@...rfivetech.com> >>>> --- >>>> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 9 +++------ >>>> 1 file changed, 3 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> index e26c3e76ebb7..baf2c5b9e92d 100644 >>>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> @@ -133,12 +133,9 @@ properties: >>>> - ptp_ref >>>> >>>> resets: >>>> - maxItems: 1 >>> >>> Also, this does not make sense on its own and messes constraints for all >>> other users. So another no for entire patch. >>> >> >> Thanks. Change the properties of 'resets' and reset-names like this: >> >> resets: >> minItems: 1 >> maxItems: 2 >> >> reset-names: >> minItems: 1 >> maxItems: 2 >> >> Is it right? Do you have any other better suggestions? > > Isn't this allowing two reset items for every variant of snps,dwmac? > Sorry for not getting back to you faster. After referring to the above modification, i used the command 'make DT_CHECKER_FLAGS=-m dt_binding_check' to check all the bindings(including 'starfive,jh7110-dwmac.yaml'), no errors are reported, and the errors reported by Rob Herring are gone. > Best regards, > Krzysztof >
Powered by blists - more mailing lists