netdev - Re: [PATCH v4 12/21] net/tcp: Verify inbound TCP-AO signed segments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Feb 2023 08:22:15 +0800
From:   kernel test robot <lkp@...el.com>
To:     Dmitry Safonov <dima@...sta.com>, linux-kernel@...r.kernel.org,
        David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Cc:     oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
        Dmitry Safonov <dima@...sta.com>,
        Andy Lutomirski <luto@...capital.net>,
        Ard Biesheuvel <ardb@...nel.org>,
        Bob Gilligan <gilligan@...sta.com>,
        Dan Carpenter <error27@...il.com>,
        David Laight <David.Laight@...lab.com>,
        Eric Biggers <ebiggers@...nel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Francesco Ruggeri <fruggeri05@...il.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Ivan Delalande <colona@...sta.com>,
        Leonard Crestez <cdleonard@...il.com>,
        Salam Noureddine <noureddine@...sta.com>
Subject: Re: [PATCH v4 12/21] net/tcp: Verify inbound TCP-AO signed segments

Hi Dmitry,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on e1c04510f521e853019afeca2a5991a5ef8d6a5b]

url:    https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230216-023836
base:   e1c04510f521e853019afeca2a5991a5ef8d6a5b
patch link:    https://lore.kernel.org/r/20230215183335.800122-13-dima%40arista.com
patch subject: [PATCH v4 12/21] net/tcp: Verify inbound TCP-AO signed segments
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230216/202302160834.wX7iq8Lo-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/9f88af338e9c573f154bba8ba7692b1756b0e216
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230216-023836
        git checkout 9f88af338e9c573f154bba8ba7692b1756b0e216
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash net/ipv4/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302160834.wX7iq8Lo-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/ipv4/tcp_ao.c:290:5: warning: no previous prototype for 'tcp_ao_calc_key_sk' [-Wmissing-prototypes]
     290 | int tcp_ao_calc_key_sk(struct tcp_ao_key *mkt, u8 *key,
         |     ^~~~~~~~~~~~~~~~~~
>> net/ipv4/tcp_ao.c:324:5: warning: no previous prototype for 'tcp_ao_calc_key_skb' [-Wmissing-prototypes]
     324 | int tcp_ao_calc_key_skb(struct tcp_ao_key *mkt, u8 *key,
         |     ^~~~~~~~~~~~~~~~~~~


vim +/tcp_ao_calc_key_skb +324 net/ipv4/tcp_ao.c

   289	
 > 290	int tcp_ao_calc_key_sk(struct tcp_ao_key *mkt, u8 *key,
   291			       const struct sock *sk,
   292			       __be32 sisn, __be32 disn,
   293			       bool send)
   294	{
   295		if (mkt->family == AF_INET)
   296			return tcp_v4_ao_calc_key_sk(mkt, key, sk, sisn, disn, send);
   297		else
   298			return tcp_v6_ao_calc_key_sk(mkt, key, sk, sisn, disn, send);
   299	}
   300	
   301	int tcp_v4_ao_calc_key_rsk(struct tcp_ao_key *mkt, u8 *key,
   302				   struct request_sock *req)
   303	{
   304		struct inet_request_sock *ireq = inet_rsk(req);
   305	
   306		return tcp_v4_ao_calc_key(mkt, key,
   307					  ireq->ir_loc_addr, ireq->ir_rmt_addr,
   308					  htons(ireq->ir_num), ireq->ir_rmt_port,
   309					  htonl(tcp_rsk(req)->snt_isn),
   310					  htonl(tcp_rsk(req)->rcv_isn));
   311	}
   312	
   313	int tcp_v4_ao_calc_key_skb(struct tcp_ao_key *mkt, u8 *key,
   314				   const struct sk_buff *skb, __be32 sisn,
   315				   __be32 disn)
   316	{
   317		const struct iphdr *iph = ip_hdr(skb);
   318		const struct tcphdr *th = tcp_hdr(skb);
   319	
   320		return tcp_v4_ao_calc_key(mkt, key, iph->saddr, iph->daddr,
   321					     th->source, th->dest, sisn, disn);
   322	}
   323	
 > 324	int tcp_ao_calc_key_skb(struct tcp_ao_key *mkt, u8 *key,
   325				const struct sk_buff *skb, __be32 sisn,
   326				__be32 disn, int family)
   327	{
   328		if (family == AF_INET)
   329			return tcp_v4_ao_calc_key_skb(mkt, key, skb, sisn, disn);
   330		else
   331			return tcp_v6_ao_calc_key_skb(mkt, key, skb, sisn, disn);
   332	}
   333	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests