netdev - Re: [PATCH intel-next v4 8/8] i40e: add support for XDP multi-buffer Rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c78c5e12-1c5a-5215-812c-b10d4b892a1b@intel.com>
Date:   Wed, 15 Feb 2023 16:02:45 -0800
From:   Tony Nguyen <anthony.l.nguyen@...el.com>
To:     Lorenzo Bianconi <lorenzo.bianconi@...hat.com>,
        Tirthendu Sarkar <tirthendu.sarkar@...el.com>
CC:     <intel-wired-lan@...ts.osuosl.org>, <jesse.brandeburg@...el.com>,
        <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        <magnus.karlsson@...el.com>, <maciej.fijalkowski@...el.com>
Subject: Re: [PATCH intel-next v4 8/8] i40e: add support for XDP multi-buffer
 Rx

On 2/15/2023 6:51 AM, Lorenzo Bianconi wrote:
>> This patch adds multi-buffer support for the i40e_driver.
>>
> 
> [...]
> 
>>   
>>   	netdev->features &= ~NETIF_F_HW_TC;
>>   	netdev->xdp_features = NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |
>> -			       NETDEV_XDP_ACT_XSK_ZEROCOPY;
>> +			       NETDEV_XDP_ACT_XSK_ZEROCOPY |
>> +			       NETDEV_XDP_ACT_RX_SG;
> 
> Hi Tirthendu,
> 
> I guess we should set it just for I40E_VSI_MAIN, I posted a patch yesterday
> to fix it:
> https://patchwork.kernel.org/project/netdevbpf/patch/f2b537f86b34fc176fbc6b3d249b46a20a87a2f3.1676405131.git.lorenzo@kernel.org/
> 
> can you please rebase on top of it?

Jakub,

I believe you are planning on taking Lorenzo's ice [1] and i40e [2] 
patch based on the comment of taking follow-ups directly [3]?

If so, Tirthendu, I'll rebase after this is pulled by netdev, then if 
you can base on next-queue so everything will apply nicely.

Thanks,
Tony

> Regards,
> Lorenzo

[1] 
https://lore.kernel.org/all/8a4781511ab6e3cd280e944eef69158954f1a15f.1676385351.git.lorenzo@kernel.org/
[2] 
https://lore.kernel.org/all/f2b537f86b34fc176fbc6b3d249b46a20a87a2f3.1676405131.git.lorenzo@kernel.org/
[3] https://lore.kernel.org/all/20230213172358.7df0f07c@kernel.org/