lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y+5ULBGJ9nlr3VS8@boxer> Date: Thu, 16 Feb 2023 17:05:00 +0100 From: Maciej Fijalkowski <maciej.fijalkowski@...el.com> To: Saeed Mahameed <saeed@...nel.org> CC: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Saeed Mahameed" <saeedm@...dia.com>, <netdev@...r.kernel.org>, Tariq Toukan <tariqt@...dia.com>, Gal Pressman <gal@...dia.com> Subject: Re: [net-next 9/9] net/mlx5e: RX, Remove doubtful unlikely call On Wed, Feb 15, 2023 at 04:09:18PM -0800, Saeed Mahameed wrote: > From: Gal Pressman <gal@...dia.com> > > When building an skb in non-linear mode, it is not likely nor unlikely > that the xdp buff has fragments, it depends on the size of the packet > received. Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com> > > Signed-off-by: Gal Pressman <gal@...dia.com> > Signed-off-by: Saeed Mahameed <saeedm@...dia.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c > index ac570945d5d2..e79dcc2a6007 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c > @@ -1718,7 +1718,7 @@ mlx5e_skb_from_cqe_nonlinear(struct mlx5e_rq *rq, struct mlx5e_wqe_frag_info *wi > > page_ref_inc(head_wi->au->page); > > - if (unlikely(xdp_buff_has_frags(&mxbuf.xdp))) { > + if (xdp_buff_has_frags(&mxbuf.xdp)) { > int i; > > /* sinfo->nr_frags is reset by build_skb, calculate again. */ > -- > 2.39.1 >
Powered by blists - more mailing lists