netdev - Re: [PATCH 1/1] wifi: ath9k: hif_usb: fix memory leak of remain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b867a165-3ca2-6ce7-4373-2a69d0a1341b@ispras.ru>
Date:   Thu, 16 Feb 2023 21:44:42 +0300
From:   Fedor Pchelkin <pchelkin@...ras.ru>
To:     Toke Høiland-Jørgensen <toke@...e.dk>
Cc:     Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "John W. Linville" <linville@...driver.com>,
        Vasanthakumar Thiagarajan <vasanth@...eros.com>,
        Senthil Balasubramanian <senthilkumar@...eros.com>,
        Sujith <Sujith.Manoharan@...eros.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH 1/1] wifi: ath9k: hif_usb: fix memory leak of remain_skbs

On 16.02.2023 21:05, Toke Høiland-Jørgensen wrote:
> Fedor Pchelkin <pchelkin@...ras.ru> writes:
>
>> On 16.02.2023 19:15, Toke Høiland-Jørgensen wrote:
>>   > Erm, does this actually fix the leak? AFAICT, ath9k_hif_usb_dev_deinit()
>>   > is only called on the error path of ath9k_hif_usb_firmware_cb(), not
>>   > when the device is subsequently torn down in
>>   > ath9k_htc_disconnect_device()?
>>
>> ath9k_hif_usb_dev_deinit() is also called inside
>> ath9k_hif_usb_disconnect().
> No it's not, as of:
>
> f099c5c9e2ba ("wifi: ath9k: Fix use-after-free in ath9k_hif_usb_disconnect()")
>
> I guess you're looking at an older tree? Please base your patches on an
> up-to-date ath-next tree.
>
Oops, that's my fault, I indeed patched the wrong tree.

Thanks for clarifying!