netdev - Re: [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Feb 2023 09:26:16 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Andrew Halaney <ahalaney@...hat.com>, devicetree@...r.kernel.org
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, alexandre.torgue@...s.st.com,
        peppe.cavallaro@...com, joabreu@...opsys.com, mripard@...nel.org,
        shenwei.wang@....com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio

On 14/02/2023 18:15, Andrew Halaney wrote:
> The deprecated property is named snps,reset-gpio, but this devicetree
> used snps,reset-gpios instead which results in the reset not being used
> and the following make dtbs_check error:
> 
>     ./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@...50000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us'
>         From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml
> 
> Use the preferred method of defining the reset gpio in the phy node
> itself. Note that this drops the 10 us pre-delay, but prior this wasn't
> used at all and a pre-delay doesn't make much sense in this context so
> it should be fine.
> 
> Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board")
> Signed-off-by: Andrew Halaney <ahalaney@...hat.com>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof