netdev - Re: [PATCH] wifi: rtl8xxxu: add LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e88fae65e85366bfc5d728c0e4c47133c7b9523.camel@realtek.com>
Date:   Fri, 17 Feb 2023 11:50:53 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     "arnd@...nel.org" <arnd@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        "Jes.Sorensen@...il.com" <Jes.Sorensen@...il.com>,
        "rtl8821cerfe2@...il.com" <rtl8821cerfe2@...il.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>
Subject: Re: [PATCH] wifi: rtl8xxxu: add LEDS_CLASS dependency

On Fri, 2023-02-17 at 10:59 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> rtl8xxxu now unconditionally uses LEDS_CLASS, so a Kconfig dependency
> is required to avoid link errors:
> 
> aarch64-linux-ld: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.o: in function
> `rtl8xxxu_disconnect':
> rtl8xxxu_core.c:(.text+0x730): undefined reference to `led_classdev_unregister'
> 
> ERROR: modpost: "led_classdev_unregister" [drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.ko]
> undefined!
> ERROR: modpost: "led_classdev_register_ext" [drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.ko]
> undefined!
> 
> Fixes: 3be01622995b ("wifi: rtl8xxxu: Register the LED and make it blink")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/wireless/realtek/rtl8xxxu/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
> b/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
> index 091d3ad98093..2eed20b0988c 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
> @@ -5,6 +5,7 @@
>  config RTL8XXXU
>         tristate "Realtek 802.11n USB wireless chips support"
>         depends on MAC80211 && USB
> +       depends on LEDS_CLASS

With 'depends on', this item will disappear if LEDS_CLASS isn't selected.
Would it use 'select' instead?

Ping-Ke