netdev - Re: [PATCH] sfc: fix builds without CONFIG_RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR12MB420241B35AB4B8846AB4F568C1A19@DM6PR12MB4202.namprd12.prod.outlook.com>
Date:   Fri, 17 Feb 2023 15:30:32 +0000
From:   "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>
To:     "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>,
        Alexander Lobakin <aleksander.lobakin@...el.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-net-drivers (AMD-Xilinx)" <linux-net-drivers@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "habetsm.xilinx@...il.com" <habetsm.xilinx@...il.com>,
        "ecree.xilinx@...il.com" <ecree.xilinx@...il.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "corbet@....net" <corbet@....net>,
        "jiri@...dia.com" <jiri@...dia.com>
Subject: Re: [PATCH] sfc: fix builds without CONFIG_RTC_LIB

BTW, I did not send the net-next tag what I'm not sure if it is required 
(I would say so).

Should I add it?

Thanks

On 2/17/23 15:20, Lucero Palau, Alejandro wrote:
> On 2/17/23 14:47, Alexander Lobakin wrote:
>> From: Lucero Palau, Alejandro <alejandro.lucero-palau@....com>
>> Date: Fri, 17 Feb 2023 10:22:36 +0000
>>
>>> From: Alejandro Lucero <alejandro.lucero-palau@....com>
>>>
>>> Adding an embarrasing missing semicolon precluding kernel building
>> :D
>>
>> 'Embarrassing' tho, with two 's'. And I guess "embarrassingly missed",
>> since a semicolon itself can't be "embarrassing" I believe? :D
> This is going worse ... :D
>
> I'll change it.
>
>> + "add", not "adding"
>> + "precluding"? You mean "breaking"?
> Preclude: "prevent from happening; make impossible."
>
> But I can use breaking instead.
>
> Thanks!
>
>>> in ia64 configs.
>>>
>>> Reported-by: kernel test robot <lkp@...el.com>
>>> Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/
>>> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
>>> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@....com>
>>> ---
>>>    drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
>>> index d2eb6712ba35..3eb355fd4282 100644
>>> --- a/drivers/net/ethernet/sfc/efx_devlink.c
>>> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
>>> @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx,
>>>    				    GET_VERSION_V2_OUT_SUCFW_BUILD_DATE);
>>>    		rtc_time64_to_tm(tstamp, &build_date);
>>>    #else
>>> -		memset(&build_date, 0, sizeof(build_date)
>>> +		memset(&build_date, 0, sizeof(build_date);
>>>    #endif
>>>    		build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
>>>    
>> Thanks,
>> Olek