netdev - Re: [PATCH] wifi: ath: Silence memcpy run-time false positive warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <167665109178.8263.14788866045287619411.kvalo@kernel.org>
Date:   Fri, 17 Feb 2023 16:24:58 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Kees Cook <keescook@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] wifi: ath: Silence memcpy run-time false positive warning

Kees Cook <keescook@...omium.org> wrote:

> The memcpy() in ath_key_config() was attempting to write across
> neighboring struct members in struct ath_keyval. Introduce a wrapping
> struct_group, kv_values, to be the addressable target of the memcpy
> without overflowing an individual member. Silences the false positive
> run-time warning:
> 
>   memcpy: detected field-spanning write (size 32) of single field "hk.kv_val" at drivers/net/wireless/ath/key.c:506 (size 16)
> 
> Link: https://bbs.archlinux.org/viewtopic.php?id=282254
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: linux-wireless@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

Patch applied to ath-next branch of ath.git, thanks.

bfcc8ba45eb8 wifi: ath: Silence memcpy run-time false positive warning

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230210054310.never.554-kees@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches