netdev - Re: [PATCH v2 net-next] sfc: fix ia64 builds without CONFIG_RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR12MB420294C790115B98DD58FCF0C1A19@DM6PR12MB4202.namprd12.prod.outlook.com>
Date:   Fri, 17 Feb 2023 19:29:57 +0000
From:   "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>
To:     Paolo Abeni <pabeni@...hat.com>,
        "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-net-drivers (AMD-Xilinx)" <linux-net-drivers@....com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "habetsm.xilinx@...il.com" <habetsm.xilinx@...il.com>,
        "ecree.xilinx@...il.com" <ecree.xilinx@...il.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "corbet@....net" <corbet@....net>,
        "jiri@...dia.com" <jiri@...dia.com>
Subject: Re: [PATCH v2 net-next] sfc: fix ia64 builds without CONFIG_RTC_LIB


On 2/17/23 17:46, Paolo Abeni wrote:
> On Fri, 2023-02-17 at 17:03 +0000, alejandro.lucero-palau@....com
> wrote:
>> From: Alejandro Lucero <alejandro.lucero-palau@....com>
>>
>> Add an embarrasingly missed semicolon breaking kernel building
>> in ia64 configs.
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/
>> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
>> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@....com>
>> ---
>>   drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
>> index d2eb6712ba35..3eb355fd4282 100644
>> --- a/drivers/net/ethernet/sfc/efx_devlink.c
>> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
>> @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx,
>>   				    GET_VERSION_V2_OUT_SUCFW_BUILD_DATE);
>>   		rtc_time64_to_tm(tstamp, &build_date);
>>   #else
>> -		memset(&build_date, 0, sizeof(build_date)
>> +		memset(&build_date, 0, sizeof(build_date);
> You missed the feedback on previous version from Manank reporting you
> should also add a final ')' above. Should be:
>
> +		memset(&build_date, 0, sizeof(build_date));
>
> Please try to build test the next version before submitting it, thanks!

I thought I did so, but obviously wrongly. The shortcut for configuring 
the kernel without CONFIG_RTC_LIC did not work but I did not notice.

It will not happen again.

Thanks

> Paolo
>