netdev - Re: [PATCH bpf-next 4/4] selftests/bpf: Add bpf_fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12ea2782-5215-46ba-3687-575e91287309@linux.dev>
Date:   Fri, 17 Feb 2023 15:08:33 -0800
From:   Martin KaFai Lau <martin.lau@...ux.dev>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     bpf@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        kernel-team@...a.com
Subject: Re: [PATCH bpf-next 4/4] selftests/bpf: Add bpf_fib_lookup test

On 2/17/23 3:02 PM, Andrii Nakryiko wrote:
>> +#define SYS(fmt, ...)                                          \
>> +       ({                                                      \
>> +               char cmd[1024];                                 \
>> +               snprintf(cmd, sizeof(cmd), fmt, ##__VA_ARGS__); \
>> +               if (!ASSERT_OK(system(cmd), cmd))               \
>> +                       goto fail;                              \
>> +       })
> 
> it's probably a high time to move this SYS() macro into test_progs.h
> and stop copy/pasting it across many test?

Make sense. will follow up.