netdev - Re: [PATCH bpf] selftests/bpf: enable mptcp before testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7aa20a67-962a-d60b-9f2d-6e22bb710c1f@linux.dev>
Date:   Thu, 16 Feb 2023 23:04:33 -0800
From:   Martin KaFai Lau <martin.lau@...ux.dev>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Mykola Lysenko <mykolal@...com>,
        Felix Maurer <fmaurer@...hat.com>,
        Davide Caratti <dcaratti@...hat.com>,
        Matthieu Baerts <matthieu.baerts@...sares.net>
Subject: Re: [PATCH bpf] selftests/bpf: enable mptcp before testing

On 2/16/23 12:13 AM, Hangbin Liu wrote:
> On Wed, Feb 15, 2023 at 10:58:20AM +0100, Matthieu Baerts wrote:
>> Hi Hangbin, Martin,
>>
>> Thank you both for your replies!
>>
>> Yes, that would be good to have this test running in a dedicated NS.
>>
>> Then mptcp.enabled can be forced using write_sysctl() or SYS("sysctl (...)".
>>
> 
> Hi Matt, Martin,
> 
> I tried to set make mptcp test in netns, like decap_sanity.c does. But I got
> error when delete the netns. e.g.
> 
> # ./test_progs -t mptcp
> Cannot remove namespace file "/var/run/netns/mptcp_ns": Device or resource busy

Could you try to create and delete netns after test__join_cgroup()?