netdev - Re: [PATCH] ip: fix UB in strncpy (e.g. truncated ip route output)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167668501783.31159.4836986808159241082.git-patchwork-notify@kernel.org>
Date:   Sat, 18 Feb 2023 01:50:17 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Sam James <sam@...too.org>
Cc:     dwfreed@....edu, freswa@...hlinux.org, netdev@...r.kernel.org,
        stephen@...workplumber.org, toolchain@...too.org
Subject: Re: [PATCH] ip: fix UB in strncpy (e.g. truncated ip route output)

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@...workplumber.org>:

On Mon, 13 Feb 2023 03:26:31 +0000 you wrote:
> Fix overlapping buffers passed to strncpy which is UB. format_host_rta_r writes
> to the buffer passed to it, so hostname (derived from b1) & b1 partly overlap.
> 
> This gets worse with sys-libs/glibc-2.37 where the ip route output can be truncated,
> but it was UB anyway and you can see it occurring w/ glibc-2.36.
> 
> Bug: https://lore.kernel.org/netdev/0011AC38-4823-4D0A-8580-B108D08959C2@gentoo.org/T/#u
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30112
> Thanks-to: Doug Freed <dwfreed@....edu>
> Signed-off-by: Sam James <sam@...too.org>
> 
> [...]

Here is the summary with links:
  - ip: fix UB in strncpy (e.g. truncated ip route output)
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=890c599ec2e8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html