netdev - Re: [PATCH] bnx2: remove deadcode in bnx2_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62832516-d4b9-add6-4925-1caeaa33d167@linux.dev>
Date:   Sat, 18 Feb 2023 16:13:19 +0000
From:   Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To:     Maxim Korotkov <korotkov.maxim.s@...il.com>,
        Rasesh Mody <rmody@...vell.com>
Cc:     GR-Linux-NIC-Dev@...vell.com,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Michael Chan <mchan@...adcom.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] bnx2: remove deadcode in bnx2_init_cpus()

On 18.02.2023 13:00, Maxim Korotkov wrote:
> The load_cpu_fw function has no error return code
> and always returns zero. Checking the value returned by
> this function does not make sense.
> As a result, bnx2_init_cpus will also return only zero
> 
In this case it's safe to convert both load_cpu_fw and bnx2_init_cpus to void 
and remove the check in bnx2_init_chip. This will reduce the code a bit.