netdev - Re: [PATCH] bnxt: avoid overflow in bnxt_get_nvram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 18 Feb 2023 22:27:47 +0530
From:   Pavan Chebbi <pavan.chebbi@...adcom.com>
To:     Maxim Korotkov <korotkov.maxim.s@...il.com>
Cc:     Michael Chan <michael.chan@...adcom.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] bnxt: avoid overflow in bnxt_get_nvram_directory()

On Sat, Feb 18, 2023 at 3:20 PM Maxim Korotkov
<korotkov.maxim.s@...il.com> wrote:
>
> The value of an arithmetic expression is subject
> of possible overflow due to a failure to cast operands to a larger data
> type before performing arithmetic. Used macro for multiplication instead
> operator for avoiding overflow.
>
> Found by Security Code and Linux Verification
> Center (linuxtesting.org) with SVACE.
>

Looks OK to me. May need a fixes tag.

> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@...il.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> index ec573127b707..696f32dfe41f 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> @@ -2862,7 +2862,7 @@ static int bnxt_get_nvram_directory(struct net_device *dev, u32 len, u8 *data)
>         if (rc)
>                 return rc;
>
> -       buflen = dir_entries * entry_length;
> +       buflen = mul_u32_u32(dir_entries, entry_length);
>         buf = hwrm_req_dma_slice(bp, req, buflen, &dma_handle);
>         if (!buf) {
>                 hwrm_req_drop(bp, req);
> --
> 2.37.2
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)