netdev - Re: [patch net-next v2] devlink: don't allow to change net namespace for FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/M23e0tJtfVhSNI@corigine.com>
Date:   Mon, 20 Feb 2023 10:01:17 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, jacob.e.keller@...el.com,
        moshe@...dia.com
Subject: Re: [patch net-next v2] devlink: don't allow to change net namespace
 for FW_ACTIVATE reload action

On Mon, Feb 13, 2023 at 12:58:36PM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> The change on network namespace only makes sense during re-init reload
> action. For FW activation it is not applicable. So check if user passed
> an ATTR indicating network namespace change request and forbid it.
> 
> Fixes: ccdf07219da6 ("devlink: Add reload action option to devlink reload command")
> Signed-off-by: Jiri Pirko <jiri@...dia.com>
> ---
> Sending to net-next as this is not actually fixing any real bug,
> it just adds a forgotten check.
> ---
> v1->v2:
> - don't fail in case the user requests change to the current namespace

Thanks for fixing my feedback on v1 and sorry for not
reviewing v2 earlier - I was taking a break last week.

For the record, and I know the patch has already been accepted,
this looks good to me.

Reviewed-by: Simon Horman <simon.horman@...igine.com>