netdev - Re: [PATCH] mt76: mt7915: expose device tree match table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d67a960a-5a24-3744-276b-bf65bdddebfb@collabora.com>
Date:   Mon, 20 Feb 2023 10:04:50 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Lorenz Brun <lorenz@...n.one>, Felix Fietkau <nbd@....name>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Ryder Lee <ryder.lee@...iatek.com>,
        Shayne Chen <shayne.chen@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Bo Jiao <Bo.Jiao@...iatek.com>,
        Peter Chiu <chui-hao.chiu@...iatek.com>,
        Sujuan Chen <sujuan.chen@...iatek.com>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] mt76: mt7915: expose device tree match table

Il 18/02/23 12:29, Lorenz Brun ha scritto:
> On MT7986 the WiFi driver currently does not get automatically loaded,
> requiring manual modprobing because the device tree compatibles are not
> exported into metadata.
> 
> Add the missing MODULE_DEVICE_TABLE macro to fix this.
> 
> Fixes: 99ad32a4ca3a2 ("mt76: mt7915: add support for MT7986")
> Signed-off-by: Lorenz Brun <lorenz@...n.one>

I don't think that this commit needs a Fixes tag, as you're only adding (good)
auto-load commodity.

Regardless of that:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>