netdev - Re: [PATCH v3 net-next] sfc: fix ia64 builds without CONFIG_RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/NNJHbIo8oTk5eO@corigine.com>
Date:   Mon, 20 Feb 2023 11:36:20 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-net-drivers (AMD-Xilinx)" <linux-net-drivers@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "habetsm.xilinx@...il.com" <habetsm.xilinx@...il.com>,
        "ecree.xilinx@...il.com" <ecree.xilinx@...il.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "corbet@....net" <corbet@....net>,
        "jiri@...dia.com" <jiri@...dia.com>
Subject: Re: [PATCH v3 net-next] sfc: fix ia64 builds without CONFIG_RTC_LIB

On Mon, Feb 20, 2023 at 10:27:01AM +0000, Lucero Palau, Alejandro wrote:
> 
> On 2/19/23 13:24, Simon Horman wrote:
> > Hi Alejandro,
> >
> > On Sat, Feb 18, 2023 at 12:56:20AM +0000, alejandro.lucero-palau@....com wrote:
> >> From: Alejandro Lucero <alejandro.lucero-palau@....com>
> >>
> >> Add an embarrassingly missed semicolon plus and embarrassingly missed
> >> parenthesis breaking kernel building in ia64 configs.
> > I think this statement is slightly misleading.
> >
> > The problem may have manifested when building for ia64 config.
> > However, I don't believe that it is, strictly speaking, an ia64 issue.
> > Rather, I believe the problem is build without CONFIG_RTC_LIB.
> >
> > Some architectures select CONFIG_RTC_LIB., f.e. x86_64. But some do not.
> > ia64 is one such example. arm64 is another - indeed I was able to reproduce
> > the bug when building for arm64 using config based on the one at the link
> > below.
> >
> > I think it would be helpful to update the patch description accordingly.
> >
> > Code change looks good to me: I exercised builds for both ia64 and arm64.
> >
> Hi Simon,
> 
> I agree. In fact, I did not initially specify ia64 in the subject, but I 
> got a warning suggesting maybe I should do it.
> 
> I guess that suggestion is likely due to adding the Reported and Link 
> tags, but as you say, it is not describing the problem properly.
> 
> I will change it in v4.
> 
> Thanks, and thank you for testing.

Likewise, thanks.