[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230220165000.1eda0afb@kernel.org>
Date: Mon, 20 Feb 2023 16:50:00 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Leon Romanovsky <leon@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>,
Patrisious Haddad <phaddad@...dia.com>,
Eric Dumazet <edumazet@...gle.com>, linux-rdma@...r.kernel.org,
Mark Zhang <markzhang@...dia.com>, netdev@...r.kernel.org,
Paolo Abeni <pabeni@...hat.com>, Raed Salem <raeds@...dia.com>,
Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH net-next] net/mlx5: Fix memory leak in IPsec RoCE
creation
On Sun, 19 Feb 2023 14:59:57 +0200 Leon Romanovsky wrote:
> -rule_fail:
> +fail_rule:
> mlx5_destroy_flow_group(roce->g);
> -fail:
> +fail_group:
> mlx5_destroy_flow_table(ft);
> +fail_table:
> + kvfree(in);
> return err;
If you're touching all of them please name them after what they do.
Much easier to review.
Powered by blists - more mailing lists