lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <DU2PR04MB8600F997FCED520DCBAB2330E7A59@DU2PR04MB8600.eurprd04.prod.outlook.com> Date: Tue, 21 Feb 2023 16:40:25 +0000 From: Neeraj sanjay kale <neeraj.sanjaykale@....com> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>, "marcel@...tmann.org" <marcel@...tmann.org>, "johan.hedberg@...il.com" <johan.hedberg@...il.com>, "luiz.dentz@...il.com" <luiz.dentz@...il.com>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "jirislaby@...nel.org" <jirislaby@...nel.org>, "alok.a.tiwari@...cle.com" <alok.a.tiwari@...cle.com>, "hdanton@...a.com" <hdanton@...a.com>, "ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>, "leon@...nel.org" <leon@...nel.org> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>, "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>, Amitkumar Karwar <amitkumar.karwar@....com>, Rohit Fule <rohit.fule@....com>, Sherry Sun <sherry.sun@....com> Subject: Re: [PATCH v3 2/3] dt-bindings: net: bluetooth: Add NXP bluetooth support Hi Krzysztof, Thank you for reviewing this patch. I have fixed all the review comments in this document. Please let me know if you have any more comments or suggestions on the new v4 patch. > > .../bindings/net/bluetooth/nxp,w8xxx-bt.yaml | 44 > > +++++++++++++++++++ > > I don't think I proposed such filename. Renamed file to nxp,w8987-bt.yaml > > +examples: > > + - | > > + uart2 { > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all requested > changes or keep discussing them. > > Thank you. > > > + uart-has-rtscts; > > + bluetooth { > > + compatible = "nxp,iw416-bt"; > > Wrong indentation. Use 4 spaces for example indentation. > Updated example indentation to use 4 spaces. Thanks, Neeraj
Powered by blists - more mailing lists